Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: "Joos, Christina" <christina.joos@intel.com>
Cc: Luis <luis.machado.foss@gmail.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	 "tom@tromey.com" <tom@tromey.com>
Subject: Re: [PATCH v4 02/13] aarch64: Implement gdbarch function top_addr_empty_shadow_stack.
Date: Sat, 29 Aug 2026 05:24:49 +0000	[thread overview]
Message-ID: <871pbhxzvi.fsf@linaro.org> (raw)
In-Reply-To: <SN7PR11MB76387551DBDA8321227566B489AF2@SN7PR11MB7638.namprd11.prod.outlook.com> (Christina Joos's message of "Tue, 25 Aug 2026 09:01:49 +0000")

Hello,

"Joos, Christina" <christina.joos@intel.com> writes:

>> -----Original Message-----
>> From: Luis <luis.machado.foss@gmail.com>
>> Sent: Donnerstag, 13. August 2026 00:13
>> To: Joos, Christina <christina.joos@intel.com>; gdb-patches@sourceware.org
>> Cc: tom@tromey.com; thiago.bauermann@linaro.org
>> Subject: Re: [PATCH v4 02/13] aarch64: Implement gdbarch function
>> top_addr_empty_shadow_stack.
>> 
>> On 08/07/2026 15:36, Christina Schimpe wrote:
>> > With the implementation of that gdbarch function we can remove the
>> > arch specific function aarch64_linux_dwarf2_prev_gcspr and use the
>> > generalized function dwarf2_prev_ssp instead.
>> >
>> > Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>

I don't understand what this tag means. Was this patch supposed to have
someone else as the author? If you're the only author, it can be
dropped.

>> Otherwise looks OK to me.

Looks OK to me too, I have nothing to add to Luis' comments.

> I will wait for more feedback for this series (Thiago indicated he will review it soon)
> and then post a new series with your and his feedback included. 

Thank you for your patience. I expect to finish reviewing early next
week.

-- 
Thiago
(he/him)

  reply	other threads:[~2026-08-29  5:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 14:36 [PATCH v4 00/13] Add new command to print the shadow stack backtrace Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 01/13] gdb: Generalize handling of the shadow stack pointer Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 02/13] aarch64: Implement gdbarch function top_addr_empty_shadow_stack Christina Schimpe
2026-08-12 22:13   ` Luis
2026-08-25  9:01     ` Joos, Christina
2026-08-29  5:24       ` Thiago Jung Bauermann [this message]
2026-07-08 14:36 ` [PATCH v4 03/13] gdb: Add get_main_func_start_pc to refactor frame.c:inside_main_func Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 04/13] gdb: Refactor 'stack.c:print_frame' Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 05/13] gdb: Introduce 'stack.c:print_pc' function without frame argument Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 06/13] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 07/13] gdb: Refactor 'stack.c:print_frame_info' Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 08/13] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 09/13] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 10/13] gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 11/13] gdb: Enable inferior calls in the shadow stack backtrace Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 12/13] gdb: Enable signal trampolines " Christina Schimpe
2026-07-08 14:36 ` [PATCH v4 13/13] gdb, mi: Add -shadow-stack-list-frames command Christina Schimpe
2026-08-04  7:45 ` RE:[PATCH v4 00/13] Add new command to print the shadow stack backtrace Joos, Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pbhxzvi.fsf@linaro.org \
    --to=thiago.bauermann@linaro.org \
    --cc=christina.joos@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox