Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page))
Date: Fri, 12 Apr 2013 18:16:00 -0000	[thread overview]
Message-ID: <87ip3riz3h.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5166923E.1070406@redhat.com> (Pedro Alves's message of "Thu, 11	Apr 2013 11:36:46 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Jan> Forgot to state here were always replies one should strip all
Jan> auto-generated parts from posted patches - so I do it.  But I find
Jan> that inconvenient.  It is easier to skip a part of patch when
Jan> reviewing it than to regenerate it hopefully the same way as the
Jan> patch submitter because the source tree requires special autotools
Jan> (old version + unpatched).

Pedro> I fully agree.  It's also very useful to see the generated bits
Pedro> to check whether a submitter who has commit/write access is using
Pedro> the right versions of the tools to regenerate the patches, and
Pedro> check whether the correct set of files is being regenerated.

I'm also not averse to changing this rule.

One drawback is that it would mean a different rule for gdb than for
other parts of the toolchain.  But that is already true in various ways.

I'd like it if non-trivial series were available in git somewhere.  Then
if someone really wanted to try the patch out it would be available
without re-applying.

Tom


  reply	other threads:[~2013-04-12 14:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 14:15 [patch 2/2+rfc+doc] Install gcore by default (+new man page) Jan Kratochvil
2013-04-08 19:41 ` Eli Zaretskii
2013-04-09  2:10   ` Jan Kratochvil
2013-04-09  8:53     ` Tom Tromey
2013-04-09  9:01       ` Jan Kratochvil
2013-04-09 14:26         ` Jan Kratochvil
2013-04-09 18:53           ` Eli Zaretskii
2013-04-09 15:29       ` Pedro Alves
2013-04-09 19:59         ` Jan Kratochvil
2013-04-10 19:49           ` Pedro Alves
2013-04-11  2:43             ` Jan Kratochvil
2013-04-11  7:40               ` Jan Kratochvil
2013-04-11 17:52                 ` auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page)) Pedro Alves
2013-04-12 18:16                   ` Tom Tromey [this message]
2013-04-11 17:49               ` [patch 2/2+rfc+doc] Install gcore by default (+new man page) Pedro Alves
2013-04-11 22:59                 ` [commit] " Jan Kratochvil
2013-04-11 23:00                   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip3riz3h.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox