Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page)
Date: Tue, 09 Apr 2013 08:53:00 -0000	[thread overview]
Message-ID: <87hajgua2o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130408172841.GA28868@host2.jankratochvil.net> (Jan	Kratochvil's message of "Mon, 8 Apr 2013 19:28:41 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Leaving it pending for RFC if gcore should be installed at all

I think it should be, because it is useful and "why not?".

Jan> and also if
Jan> current
Jan> 	src/gdb/gcore.in + src/gdb/gcore
Jan> should not be called for example like before
Jan> 	src/gdb/gdb_gcore.sh.in + src/gdb/gdb_gcore.sh

I like your new naming.

Jan> <tab>-completion) or if it should not be called with .sh as
Jan> 	src/gdb/gcore.sh.in + src/gdb/gcore.sh
Jan> although I do not see a reason for it, there are some *.sh files but those are
Jan> not installed.

I think having ".sh" on an installed script is a mistake.
For one thing, if you change the implementation of the command then you
get confusion -- either the ".sh" is actively wrong, or you have to change
the name.

Jan> Also I hope 755 should remain valid without a need for explicit
Jan> chmod during make install.

I thought INSTALL_PROGRAM handled this, but I see it doesn't.
Weird.  Anyway I would not worry about it.

Maybe you need one at AC_CONFIG_FILES time, like:

    AC_CONFIG_FILES([gcore], [chmod +x gcore])

I'm not sure if this is strictly needed or not.

Tom


  reply	other threads:[~2013-04-08 18:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 14:15 Jan Kratochvil
2013-04-08 19:41 ` Eli Zaretskii
2013-04-09  2:10   ` Jan Kratochvil
2013-04-09  8:53     ` Tom Tromey [this message]
2013-04-09  9:01       ` Jan Kratochvil
2013-04-09 14:26         ` Jan Kratochvil
2013-04-09 18:53           ` Eli Zaretskii
2013-04-09 15:29       ` Pedro Alves
2013-04-09 19:59         ` Jan Kratochvil
2013-04-10 19:49           ` Pedro Alves
2013-04-11  2:43             ` Jan Kratochvil
2013-04-11  7:40               ` Jan Kratochvil
2013-04-11 17:52                 ` auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page)) Pedro Alves
2013-04-12 18:16                   ` Tom Tromey
2013-04-11 17:49               ` [patch 2/2+rfc+doc] Install gcore by default (+new man page) Pedro Alves
2013-04-11 22:59                 ` [commit] " Jan Kratochvil
2013-04-11 23:00                   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hajgua2o.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox