From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15970 invoked by alias); 12 Apr 2013 14:48:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15961 invoked by uid 89); 12 Apr 2013 14:48:53 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Apr 2013 14:48:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3CEmqUl003610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Apr 2013 10:48:52 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3CEmofd032098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 12 Apr 2013 10:48:51 -0400 From: Tom Tromey To: Pedro Alves Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page)) References: <20130407185443.GB15389@host2.jankratochvil.net> <83r4ilawlx.fsf@gnu.org> <20130408172841.GA28868@host2.jankratochvil.net> <87hajgua2o.fsf@fleche.redhat.com> <516424FE.4050307@redhat.com> <20130409165525.GA29570@host2.jankratochvil.net> <51654DF0.3090101@redhat.com> <20130410194910.GA3941@host2.jankratochvil.net> <20130411040309.GA20577@host2.jankratochvil.net> <5166923E.1070406@redhat.com> Date: Fri, 12 Apr 2013 18:16:00 -0000 In-Reply-To: <5166923E.1070406@redhat.com> (Pedro Alves's message of "Thu, 11 Apr 2013 11:36:46 +0100") Message-ID: <87ip3riz3h.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00389.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Jan> Forgot to state here were always replies one should strip all Jan> auto-generated parts from posted patches - so I do it. But I find Jan> that inconvenient. It is easier to skip a part of patch when Jan> reviewing it than to regenerate it hopefully the same way as the Jan> patch submitter because the source tree requires special autotools Jan> (old version + unpatched). Pedro> I fully agree. It's also very useful to see the generated bits Pedro> to check whether a submitter who has commit/write access is using Pedro> the right versions of the tools to regenerate the patches, and Pedro> check whether the correct set of files is being regenerated. I'm also not averse to changing this rule. One drawback is that it would mean a different rule for gdb than for other parts of the toolchain. But that is already true in various ways. I'd like it if non-trivial series were available in git somewhere. Then if someone really wanted to try the patch out it would be available without re-applying. Tom