From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Clean up ptid.h/ptid.c.
Date: Thu, 03 Oct 2013 17:12:00 -0000 [thread overview]
Message-ID: <87ioxez3ct.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1380809351-20800-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 3 Oct 2013 15:09:11 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> So this gets rid of all the unnecessary descriptions, leaving only the
Pedro> ones near the function declarations in the header file, and
Pedro> fixes/clarifies those that remain.
Pedro> Comments?
Looks good to me.
It's my preferred approach.
Pedro> -/* Create a ptid given the necessary PID, LWP, and TID components. */
Pedro> -
Pedro> ptid_t
Pedro> ptid_build (int pid, long lwp, long tid)
Pedro> {
I usually write /* See ptid.h. */ in these spots.
Tom
next prev parent reply other threads:[~2013-10-03 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 14:09 Pedro Alves
2013-10-03 17:12 ` Tom Tromey [this message]
2013-10-04 10:07 ` Pedro Alves
2013-10-04 7:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioxez3ct.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox