From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Clean up ptid.h/ptid.c.
Date: Fri, 04 Oct 2013 07:30:00 -0000 [thread overview]
Message-ID: <20131004073037.GA3326@adacore.com> (raw)
In-Reply-To: <1380809351-20800-1-git-send-email-palves@redhat.com>
> So this gets rid of all the unnecessary descriptions, leaving only the
> ones near the function declarations in the header file, and
> fixes/clarifies those that remain.
>
> Comments?
I like it!
Thanks for doing this cleanup, Pedro.
> gdb/
> 2013-10-04 Pedro Alves <palves@redhat.com>
>
> * common/ptid.c (null_ptid, minus_one_ptid, ptid_build)
> (pid_to_ptid, ptid_get_pid, ptid_get_lwp, ptid_get_tid)
> (ptid_equal, ptid_is_pid, ptid_lwp_p, ptid_tid_p): Remove
> describing comments.
> * common/ptid.h: Remove intro description of constructors,
> accessors and predicates.
> (struct ptid): Reformat.
> (minus_one_ptid, ptid_build, pid_to_ptid, ptid_get_pid)
> (ptid_get_lwp, ptid_get_tid, ptid_equal, ptid_is_pid): Change
> describing comments.
--
Joel
prev parent reply other threads:[~2013-10-04 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 14:09 Pedro Alves
2013-10-03 17:12 ` Tom Tromey
2013-10-04 10:07 ` Pedro Alves
2013-10-04 7:30 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004073037.GA3326@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox