From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27436 invoked by alias); 4 Oct 2013 07:30:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27422 invoked by uid 89); 4 Oct 2013 07:30:43 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 04 Oct 2013 07:30:43 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B774A116509; Fri, 4 Oct 2013 03:30:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yBg+KTeFtAVE; Fri, 4 Oct 2013 03:30:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EB338116402; Fri, 4 Oct 2013 03:30:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 20AECE04C3; Fri, 4 Oct 2013 09:30:37 +0200 (CEST) Date: Fri, 04 Oct 2013 07:30:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up ptid.h/ptid.c. Message-ID: <20131004073037.GA3326@adacore.com> References: <1380809351-20800-1-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380809351-20800-1-git-send-email-palves@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00128.txt.bz2 > So this gets rid of all the unnecessary descriptions, leaving only the > ones near the function declarations in the header file, and > fixes/clarifies those that remain. > > Comments? I like it! Thanks for doing this cleanup, Pedro. > gdb/ > 2013-10-04 Pedro Alves > > * common/ptid.c (null_ptid, minus_one_ptid, ptid_build) > (pid_to_ptid, ptid_get_pid, ptid_get_lwp, ptid_get_tid) > (ptid_equal, ptid_is_pid, ptid_lwp_p, ptid_tid_p): Remove > describing comments. > * common/ptid.h: Remove intro description of constructors, > accessors and predicates. > (struct ptid): Reformat. > (minus_one_ptid, ptid_build, pid_to_ptid, ptid_get_pid) > (ptid_get_lwp, ptid_get_tid, ptid_equal, ptid_is_pid): Change > describing comments. -- Joel