From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9968 invoked by alias); 3 Oct 2013 17:12:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9949 invoked by uid 89); 3 Oct 2013 17:12:06 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2013 17:12:06 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r93HBWxJ008666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Oct 2013 13:11:32 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r93HBUGT025034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 3 Oct 2013 13:11:31 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up ptid.h/ptid.c. References: <1380809351-20800-1-git-send-email-palves@redhat.com> Date: Thu, 03 Oct 2013 17:12:00 -0000 In-Reply-To: <1380809351-20800-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 3 Oct 2013 15:09:11 +0100") Message-ID: <87ioxez3ct.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00119.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So this gets rid of all the unnecessary descriptions, leaving only the Pedro> ones near the function declarations in the header file, and Pedro> fixes/clarifies those that remain. Pedro> Comments? Looks good to me. It's my preferred approach. Pedro> -/* Create a ptid given the necessary PID, LWP, and TID components. */ Pedro> - Pedro> ptid_t Pedro> ptid_build (int pid, long lwp, long tid) Pedro> { I usually write /* See ptid.h. */ in these spots. Tom