Re: [PATCH 0/4] New "set cwd" command

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Wednesday, September 13 2017, Pedro Alves wrote:

> On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote:
>> This patch series is a followup of the discussion that happened at:
>> 
>>   https://sourceware.org/ml/gdb-patches/2017-09/msg00160.html
>> 
>> It implements a new GDB command, "set cwd", which is used to set the
>> current working directory of the inferior that will be started.  This
>> is a GDB-only command for now; its gdbserver counterpart will come
>> later.
>
> I think I'd prefer that the gdbserver counterpart was included
> as part of the same series.  I.e., I'd like to see the gdbserver
> side explored first before we change the native side and commit
> to the commands/interface.  Also, I think that would help make
> sure that the manual documentation is adjusted in a way that
> naturally reads as applying to local and remote.

Fair enough.

I wasn't sure if I should submit the gdbserver part as well, of just the
GDB one.  I opted to just touch GDB because we usually choose to go
"baby steps" on things.

> For example, we currently say
>
>  "Each time you start your program with @code{run}, it inherits its 
>  working directory from the current working directory of
>  @value{GDBN}.", 
>
> but you didn't change that particular sentence, which seems to leave
> it a bit incorrect.  I think we should say instead say that
> when you start your program with run, the inferior starts with
> the directory specified by "set cwd", and then mention that
> if that is not set, then the inferior inherits gdb's current
> directory if native debugging, and gdbserver's if remote debugging.
> Right?

Yeah, maybe I should rewrite this sentence indeed.  It's not entirely
true.  Thanks for catching that.

As I said, I will prepare a patch series containing the gdbserver
modifications and will submit it, along with the other changes you
proposed in the other e-mails.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/