Re: [PATCH v3 4/5] Implement "set cwd" command on GDB

[Pedro Alves <palves@redhat.com>]

On 09/22/2017 09:02 AM, Eli Zaretskii wrote:
>> From: Sergio Durigan Junior <sergiodj@redhat.com>

> 
>> +@kindex set cwd
>> +@cindex change inferior's working directory
>> +@item set cwd @r{[}@var{directory}@r{]}
>> +Set the inferior's working directory to @var{directory}.  If not
>> +given, @var{directory} uses @file{'~'}.
> 
> I think we should document here what does "~" mean on MS-Windows,
> especially since, when HOME is not in the environment, Gnulib's glob
> module doesn't behave according to MS platform recommendations (which
> say not to create files directly below %HOMEDRIVE%%HOMEPATH%).
> 
> More generally, I think we should say here that the argument is
> glob-expanded, because this is user-visible behavior (right?).  Also,
> how will TAB-completion react to input of this command? will it expand
> the input typed so far?

Actually, should the command default to ~ at all?  Shouldn't we
make "set cwd" clear the setting to the default state, i.e.,
empty?  Otherwise, how do you get back to the default state?

>> +@kindex show cwd
>> +@cindex show inferior's working directory
>> +@item show cwd
>> +Show the inferior's working directory.  If no directory has been
>> +specified by @code{set cwd}, then the default inferior's working
>> +directory is the same as @value{GDBN}'s working directory.
> 
> Does this show the original value typed by the user, or the expanded
> value?  E.g., if the user types "set cwd ~/foo", what will "show cwd"
> display?  If it shows the unexpanded form, does that mean the actual
> cwd will change if, say, HOME changes?
> 
> Should we store the cwd after tilde-expansion?

I don't think so, because this is an inferior setting.  I.e.,
e.g., when remote debugging, only the target (remote side) can
do the expansion, and the user may set this before connecting
to a target (remote, native, etc.), even.

Thanks,
Pedro Alves