From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69429 invoked by alias); 13 Sep 2017 21:54:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69417 invoked by uid 89); 13 Sep 2017 21:54:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Sep 2017 21:54:17 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A90D356CC for ; Wed, 13 Sep 2017 21:54:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0A90D356CC Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D84095D763; Wed, 13 Sep 2017 21:54:15 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH 0/4] New "set cwd" command References: <20170912042325.14927-1-sergiodj@redhat.com> Date: Wed, 13 Sep 2017 21:54:00 -0000 Message-ID: <87ingmz2m0.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00363.txt.bz2 On Wednesday, September 13 2017, Pedro Alves wrote: > On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote: >> This patch series is a followup of the discussion that happened at: >> >> https://sourceware.org/ml/gdb-patches/2017-09/msg00160.html >> >> It implements a new GDB command, "set cwd", which is used to set the >> current working directory of the inferior that will be started. This >> is a GDB-only command for now; its gdbserver counterpart will come >> later. > > I think I'd prefer that the gdbserver counterpart was included > as part of the same series. I.e., I'd like to see the gdbserver > side explored first before we change the native side and commit > to the commands/interface. Also, I think that would help make > sure that the manual documentation is adjusted in a way that > naturally reads as applying to local and remote. Fair enough. I wasn't sure if I should submit the gdbserver part as well, of just the GDB one. I opted to just touch GDB because we usually choose to go "baby steps" on things. > For example, we currently say > > "Each time you start your program with @code{run}, it inherits its > working directory from the current working directory of > @value{GDBN}.", > > but you didn't change that particular sentence, which seems to leave > it a bit incorrect. I think we should say instead say that > when you start your program with run, the inferior starts with > the directory specified by "set cwd", and then mention that > if that is not set, then the inferior inherits gdb's current > directory if native debugging, and gdbserver's if remote debugging. > Right? Yeah, maybe I should rewrite this sentence indeed. It's not entirely true. Thanks for catching that. As I said, I will prepare a patch series containing the gdbserver modifications and will submit it, along with the other changes you proposed in the other e-mails. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/