Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing
Date: Wed, 29 Aug 2018 18:58:00 -0000	[thread overview]
Message-ID: <87in3t3sqb.fsf@tromey.com> (raw)
In-Reply-To: <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> (Pedro Alves's	message of "Wed, 29 Aug 2018 19:39:30 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +  {-1, GDB_SIGNAL_UNKNOWN}

Pedro> I guess that -1 would still cause a -Wnarrowing warning.
Pedro> If so, it'd be easily fixable by removing that terminator
Pedro> entry and using range-for in the other #if 0 block.
Pedro> Just thinking out loud.  Please don't bother.

I didn't consider this, oops.
I rebuilt without the new #if and, yes, it failed.
So, I've added a DWORD cast there as well; then restore the #if.

I'm going to push this version.

thanks,
Tom


  reply	other threads:[~2018-08-29 18:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 17:43 Tom Tromey
2018-08-29 18:39 ` Pedro Alves
2018-08-29 18:58   ` Tom Tromey [this message]
2018-08-29 19:01     ` Tom Tromey
2018-08-29 19:09       ` Pedro Alves
2018-08-29 19:31         ` Tom Tromey
2018-08-29 19:16       ` Eli Zaretskii
2018-08-29 19:22         ` Tom Tromey
2018-08-29 19:29           ` Eli Zaretskii
2018-08-29 19:33             ` Eli Zaretskii
2018-08-29 19:35               ` Tom Tromey
2018-08-29 19:38                 ` Eli Zaretskii
2018-08-29 19:34             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in3t3sqb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox