Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>,
	 palves@redhat.com,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing
Date: Wed, 29 Aug 2018 19:22:00 -0000	[thread overview]
Message-ID: <87a7p53rm4.fsf@tromey.com> (raw)
In-Reply-To: <83a7p52dbh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Aug	2018 22:16:34 +0300")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> Why did you need to make .them be DWORD?  I think it should be a
Eli> 'long', and then you can use -1L without any trouble.

Thanks for the suggestion.  I tried this just now but long doesn't work
without additional casts:

../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225477' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing]
 };
 ^
../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225725' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '2147483651' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '2147483652' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing]
../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225614' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing]

Tom


  reply	other threads:[~2018-08-29 19:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 17:43 Tom Tromey
2018-08-29 18:39 ` Pedro Alves
2018-08-29 18:58   ` Tom Tromey
2018-08-29 19:01     ` Tom Tromey
2018-08-29 19:09       ` Pedro Alves
2018-08-29 19:31         ` Tom Tromey
2018-08-29 19:16       ` Eli Zaretskii
2018-08-29 19:22         ` Tom Tromey [this message]
2018-08-29 19:29           ` Eli Zaretskii
2018-08-29 19:33             ` Eli Zaretskii
2018-08-29 19:35               ` Tom Tromey
2018-08-29 19:38                 ` Eli Zaretskii
2018-08-29 19:34             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7p53rm4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox