From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33644 invoked by alias); 29 Aug 2018 19:22:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33046 invoked by uid 89); 29 Aug 2018 19:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 19:22:55 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 6F600244E434 for ; Wed, 29 Aug 2018 14:22:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v62ufJPNSBcCXv638fnZLK; Wed, 29 Aug 2018 14:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wqbjO+RJ69YgbVlFURl4BkHgY7v1/tZG6rwJ+GNHquY=; b=xom9ox1DBidwetV3yppiHW7uCo ln90uoHoZVIFlSeenJNX17rSDs2AeqQMYRUxavIjWd2/ZU0EfrusVkb6IRwYmvcnxVwBQL30SZzII p9SxbydRI3/fzytTGIHMkWhIJ; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:53102 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fv62u-003Gu9-3U; Wed, 29 Aug 2018 14:22:28 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing References: <20180829174253.18507-1-tom@tromey.com> <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> <87in3t3sqb.fsf@tromey.com> <87efeh3snr.fsf@tromey.com> <83a7p52dbh.fsf@gnu.org> Date: Wed, 29 Aug 2018 19:22:00 -0000 In-Reply-To: <83a7p52dbh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Aug 2018 22:16:34 +0300") Message-ID: <87a7p53rm4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00771.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Why did you need to make .them be DWORD? I think it should be a Eli> 'long', and then you can use -1L without any trouble. Thanks for the suggestion. I tried this just now but long doesn't work without additional casts: ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225477' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] }; ^ ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225725' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '2147483651' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '2147483652' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225614' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] Tom