From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108112 invoked by alias); 29 Aug 2018 18:58:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108103 invoked by uid 89); 29 Aug 2018 18:58:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 18:58:49 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id B9F4875CC for ; Wed, 29 Aug 2018 13:58:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v5fafIuEybXuJv5fpfeCgO; Wed, 29 Aug 2018 13:58:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CN+57e7XPydkGuPWjtaIDxyIi03nKxkiZjahK7szCG8=; b=lihWi7dYUjCSzxZjKc0ADOiWId jXrNW6596NIfa4foa9L2Hxhdr9c9dCcirXuIbfhCETmaWZIWHYUn3QzTLphmtywJeugA5SRNpdrWd jL1XaDzbN08Jeprg3YesUksnt; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:52824 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fv5fZ-003BGt-Or; Wed, 29 Aug 2018 13:58:21 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing References: <20180829174253.18507-1-tom@tromey.com> <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> Date: Wed, 29 Aug 2018 18:58:00 -0000 In-Reply-To: <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> (Pedro Alves's message of "Wed, 29 Aug 2018 19:39:30 +0100") Message-ID: <87in3t3sqb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00766.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> + {-1, GDB_SIGNAL_UNKNOWN} Pedro> I guess that -1 would still cause a -Wnarrowing warning. Pedro> If so, it'd be easily fixable by removing that terminator Pedro> entry and using range-for in the other #if 0 block. Pedro> Just thinking out loud. Please don't bother. I didn't consider this, oops. I rebuilt without the new #if and, yes, it failed. So, I've added a DWORD cast there as well; then restore the #if. I'm going to push this version. thanks, Tom