From: Sergio Durigan Junior via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Sergio Durigan Junior via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Change handling of '!' operator in stap probes
Date: Wed, 20 Jan 2021 13:55:11 -0500 [thread overview]
Message-ID: <87im7ro2uo.fsf@paluero> (raw)
In-Reply-To: <87sg6v5u54.fsf@tromey.com> (Tom Tromey's message of "Wed, 20 Jan 2021 11:40:39 -0700")
On Wednesday, January 20 2021, Tom Tromey wrote:
> Sergio> gdb/ChangeLog:
> Sergio> 2021-01-03 Sergio Durigan Junior <sergiodj@sergiodj.net>
> Sergio> Tom Tromey <tom@tromey.com>
>
> Sergio> * stap-probe.c (stap_parse_single_operand): Handle '!'
> Sergio> operator.
> Sergio> (stap_parse_argument_conditionally): Likewise.
> Sergio> Skip spaces after processing open-parenthesis sub-expression.
> Sergio> (stap_parse_argument_1): Skip spaces after call to
> Sergio> stap_parse_argument_conditionally.
> Sergio> Handle case when right-side expression is a parenthesized
> Sergio> sub-expression.
> Sergio> Skip spaces after call to stap_parse_argument_1.
>
> Sergio> gdb/testsuite/ChangeLog:
> Sergio> 2021-01-03 Sergio Durigan Junior <sergiodj@sergiodj.net>
>
> Sergio> * gdb.arch/amd64-stap-expressions.S: New file.
> Sergio> * gdb.arch/amd64-stap-expressions.exp: New file.
>
> Looks good. Thank you for doing this.
Thanks for the review, Tom.
Pushed: 6f52fdf40465ee8f5421c66ceb21f37856bf6e5e
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/
prev parent reply other threads:[~2021-01-20 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 23:02 Tom Tromey
2021-01-03 7:59 ` Sergio Durigan Junior via Gdb-patches
2021-01-12 15:52 ` Sergio Durigan Junior via Gdb-patches
2021-01-18 2:49 ` Sergio Durigan Junior via Gdb-patches
2021-01-20 18:40 ` Tom Tromey
2021-01-20 18:55 ` Sergio Durigan Junior via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im7ro2uo.fsf@paluero \
--to=gdb-patches@sourceware.org \
--cc=sergiodj@sergiodj.net \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox