From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3sReN5N8CGDWYAAAWB0awg (envelope-from ) for ; Wed, 20 Jan 2021 13:55:15 -0500 Received: by simark.ca (Postfix, from userid 112) id D2F121EF80; Wed, 20 Jan 2021 13:55:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C8CA1E945 for ; Wed, 20 Jan 2021 13:55:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A481396EC94; Wed, 20 Jan 2021 18:55:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A481396EC94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611168914; bh=/q305RAsc4XOK45pyqufARhW4wicpVqHsyHrF8S83fw=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QYKaZ03/x8ch4H8Dwlmh2YhnpnRe5cFw0Qyvweffb3vj0N7wmAYZRXAPAW6d0je5K h8bF2rJLU9ST9lDKQGuUDbqJ2eqV2RF+bvEkhMgJbYyyTgKGLOrfJ9efa6m+J2Tbuf q0YsFnidnllPTsqWdbQ8QCSG88KsQp60y17CplJc= Received: from mail.sergiodj.net (mail.sergiodj.net [IPv6:2607:5300:60:3666::3]) by sourceware.org (Postfix) with ESMTPS id 4F428396EC8E for ; Wed, 20 Jan 2021 18:55:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4F428396EC8E Received: from localhost (bras-base-toroon1016w-grc-31-76-64-52-221.dsl.bell.ca [76.64.52.221]) by mail.sergiodj.net (Postfix) with ESMTPSA id 9B5ABA00BB; Wed, 20 Jan 2021 13:55:11 -0500 (EST) To: Tom Tromey Subject: Re: [PATCH] Change handling of '!' operator in stap probes References: <20201231230205.264712-1-tom@tromey.com> <87h7ny30xu.fsf@paluero> <87sg6v5u54.fsf@tromey.com> X-URL: http://blog.sergiodj.net Date: Wed, 20 Jan 2021 13:55:11 -0500 In-Reply-To: <87sg6v5u54.fsf@tromey.com> (Tom Tromey's message of "Wed, 20 Jan 2021 11:40:39 -0700") Message-ID: <87im7ro2uo.fsf@paluero> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergio Durigan Junior via Gdb-patches Reply-To: Sergio Durigan Junior Cc: Sergio Durigan Junior via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wednesday, January 20 2021, Tom Tromey wrote: > Sergio> gdb/ChangeLog: > Sergio> 2021-01-03 Sergio Durigan Junior > Sergio> Tom Tromey > > Sergio> * stap-probe.c (stap_parse_single_operand): Handle '!' > Sergio> operator. > Sergio> (stap_parse_argument_conditionally): Likewise. > Sergio> Skip spaces after processing open-parenthesis sub-expression. > Sergio> (stap_parse_argument_1): Skip spaces after call to > Sergio> stap_parse_argument_conditionally. > Sergio> Handle case when right-side expression is a parenthesized > Sergio> sub-expression. > Sergio> Skip spaces after call to stap_parse_argument_1. > > Sergio> gdb/testsuite/ChangeLog: > Sergio> 2021-01-03 Sergio Durigan Junior > > Sergio> * gdb.arch/amd64-stap-expressions.S: New file. > Sergio> * gdb.arch/amd64-stap-expressions.exp: New file. > > Looks good. Thank you for doing this. Thanks for the review, Tom. Pushed: 6f52fdf40465ee8f5421c66ceb21f37856bf6e5e -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/