Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] [gdb/testsuite] Fixes in gdb.python/py-rbreak.exp
Date: Wed, 16 Sep 2026 09:18:46 -0600	[thread overview]
Message-ID: <87ik45usvd.fsf@tromey.com> (raw)
In-Reply-To: <20260916095243.3040533-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 16 Sep 2026 11:52:39 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> This series consists of 4 patches improving test-case gdb.python/py-rbreak.exp.
Tom> The first makes matching more strict.
Tom> The second improves readability.
Tom> The third fixes an incorrect test name.
Tom> The fourth speeds up the test-case by not running to main.

This all seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>

For patch #1, I don't really care if test names change.
In this particular case the choice of name to match was too generic, an
issue we have pretty frequently when system debuginfo is installed.
However your patch #4 removes this problem in a different way, so IMO
the series is fine as is.

thanks,
Tom

      parent reply	other threads:[~2026-09-16 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  9:52 Tom de Vries
2026-09-16  9:52 ` [PATCH 1/4] [gdb/testsuite] Use strict regexp " Tom de Vries
2026-09-16  9:52 ` [PATCH 2/4] [gdb/testsuite] Make gdb.python/py-rbreak.exp more readable Tom de Vries
2026-09-16  9:52 ` [PATCH 3/4] [gdb/testsuite] Fix test name in gdb.python/py-rbreak.exp Tom de Vries
2026-09-16  9:52 ` [PATCH 4/4] [gdb/testsuite] Speed up gdb.python/py-rbreak.exp Tom de Vries
2026-09-16 15:18 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik45usvd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox