Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/4] [gdb/testsuite] Make gdb.python/py-rbreak.exp more readable
Date: Wed, 16 Sep 2026 11:52:41 +0200	[thread overview]
Message-ID: <20260916095243.3040533-3-tdevries@suse.de> (raw)
In-Reply-To: <20260916095243.3040533-1-tdevries@suse.de>

Make gdb.python/py-rbreak.exp more readable by:
- adding empty lines between groups of tests, and
- reducing escaping using {} and subst_vars.
---
 gdb/testsuite/gdb.python/py-rbreak.exp | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp
index 731ac7bbdb3..2d5fb33f666 100644
--- a/gdb/testsuite/gdb.python/py-rbreak.exp
+++ b/gdb/testsuite/gdb.python/py-rbreak.exp
@@ -31,7 +31,8 @@ if {![runto_main]} {
 }
 
 gdb_test_no_output "nosharedlibrary"
-gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \
+
+gdb_py_test_silent_cmd {py sl = gdb.rbreak("",minsyms=False)} \
     "get all function breakpoints" 0
 set min_breakpoints 11
 gdb_test_multiple "py print(len(sl))" \
@@ -41,7 +42,8 @@ gdb_test_multiple "py print(len(sl))" \
 	    gdb_assert { $n >= $min_breakpoints } $gdb_test_name
 	}
     }
-gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"main\.\*\",minsyms=False)" \
+
+gdb_py_test_silent_cmd {py sl = gdb.rbreak("main.*",minsyms=False)} \
     "get main function breakpoint" 0
 gdb_test "py print(len(sl))" "1" \
     "check number of returned breakpoints is 1"
@@ -53,18 +55,23 @@ gdb_py_test_silent_cmd "py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle
     "get functions matching func.*" 0
 gdb_test "py print(len(sl))" "9" \
     "check number of returned breakpoints is 9"
+
 gdb_test "py gdb.rbreak($re_func_efunc,minsyms=False,throttle=5)" \
     "Number of breakpoints exceeds throttled maximum.*" \
     "check throttle errors on too many breakpoints"
-gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"func1\",minsyms=True)" \
+
+gdb_py_test_silent_cmd {py sl = gdb.rbreak("func1",minsyms=True)} \
     "including minimal symbols, get functions matching func.*" 0
 gdb_test "py print(len(sl))" "2" \
     "check number of returned breakpoints is 2"
-gdb_py_test_silent_cmd "python sym = gdb.lookup_symbol(\"efunc1\")" \
+
+gdb_py_test_silent_cmd {python sym = gdb.lookup_symbol("efunc1")} \
     "find a symbol in objfile" 1
-gdb_py_test_silent_cmd "python symtab = sym\[0\].symtab" \
+gdb_py_test_silent_cmd {python symtab = sym[0].symtab} \
     "get backing symbol table" 1
-gdb_py_test_silent_cmd "py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle=10,symtabs=\[symtab\])" \
+gdb_py_test_silent_cmd \
+    [subst_vars \
+	 {py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle=10,symtabs=[symtab])}] \
     "get functions matching func.* in one symtab only" 0
 gdb_test "py print(len(sl))" "3" \
     "check number of returned breakpoints is 3"
-- 
2.51.0


  parent reply	other threads:[~2026-09-16  9:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  9:52 [PATCH 0/4] [gdb/testsuite] Fixes in gdb.python/py-rbreak.exp Tom de Vries
2026-09-16  9:52 ` [PATCH 1/4] [gdb/testsuite] Use strict regexp " Tom de Vries
2026-09-16  9:52 ` Tom de Vries [this message]
2026-09-16  9:52 ` [PATCH 3/4] [gdb/testsuite] Fix test name " Tom de Vries
2026-09-16  9:52 ` [PATCH 4/4] [gdb/testsuite] Speed up gdb.python/py-rbreak.exp Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916095243.3040533-3-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox