From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cQ2DIi9nqmrQ7xEAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 05:53:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxrfceC/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Oc9iczKg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MWg2yHU4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C7pSX22A; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 856BF1E06B; Wed, 16 Sep 2026 05:53:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E6ABB1E066 for ; Wed, 16 Sep 2026 05:53:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 110374BA2E36 for ; Wed, 16 Sep 2026 09:53:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 110374BA2E36 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxrfceC/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Oc9iczKg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MWg2yHU4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C7pSX22A Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id C667A4BA2E2F for ; Wed, 16 Sep 2026 09:52:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C667A4BA2E2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C667A4BA2E2F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789552374; cv=none; b=XCwPcWt/flEA2qAKeiPMeqjnsMMM8XPPiIqWPD2Xmsn0K4SPJ1PPEA6ynttUibnI4zljXMlQNUbMGJYZbx1V/Nv40dg6Xn3w8fIMigK8LViagXGFYYvUAb6mchKy8oJDYPVIj1t/NPrBjQ7yygN1jaFf5E3vz7W/t+4DLlUyxHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789552374; c=relaxed/simple; bh=SsPnIMaI5PriqRN8UZwkMkOG+81n1PxorLtJhdTfQ5s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=AuLVfUv1s3Du7BEVVVkEszzAdm1kgFyo6OKwMkhC4XZcZ+jqLYwpiDRsR/KIOwR2xdr0N0Naxx4Qbk/Cou/WsptxdOQWpR9LfCxZVqEnqTBsQaw/BOivrncMp54t8LPvgDbq+QD02eS3W5J6h1ww6Ca2bLs6fza1iJXjqabjkcg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxrfceC/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Oc9iczKg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MWg2yHU4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C7pSX22A DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C667A4BA2E2F Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5CA7021B0D for ; Wed, 16 Sep 2026 09:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789552368; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZTdCEDZcFRkeBNuLNIULXF/82PSIyEMq84EB0YoK5M=; b=KxrfceC/t7hdGFoUGs6uIVQA+2fu6B6Ytm+KvaEky7UYbU95FkBdtmytKGPic6MjtvgbPx IO3cFTi0q1zMfLCHXQGJ1TZC74cbAwIm1PU0tFB7jfGAlxOybQ40M3azhZN2IGdZ3T4Exd dv7D6w0O+b0SP8RIhRnG1zApH6LZsHU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789552368; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZTdCEDZcFRkeBNuLNIULXF/82PSIyEMq84EB0YoK5M=; b=Oc9iczKgp3DhQ3D6ALSkvX+gn9cePysSaXY3s4+WeLN8luVWLVuq4bQJPuiEgJFQF/1qrZ PE6RLJks+O1D32DA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789552364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZTdCEDZcFRkeBNuLNIULXF/82PSIyEMq84EB0YoK5M=; b=MWg2yHU4X0LybZHWJ8aGKtCVE+if3IjUAXjlVHvAePDvGV1xZ/f5u7j/kik9xMijl+oANA KUbJTaehZeMM6Jvp4Q3+zFHJxFSErEgAsJI7BCHIbIKueZo5Emfww+p5p/wJn54J/ibep/ P1vfgf1n5duU7uEKHYv0SaoPWzyHnVQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789552364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZTdCEDZcFRkeBNuLNIULXF/82PSIyEMq84EB0YoK5M=; b=C7pSX22A3VgXs1k2V0IVmKgWomkSjZXqwZzTpdjV5qb2GDPaBRdSxiiJmrLaSa3UiykMpS FWG/h/AJRAd2qiBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 24262136DB for ; Wed, 16 Sep 2026 09:52:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id omSCKetmqmqMMQAAD6G6ig:T3 (envelope-from ) for ; Wed, 16 Sep 2026 09:52:44 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/4] [gdb/testsuite] Make gdb.python/py-rbreak.exp more readable Date: Wed, 16 Sep 2026 11:52:41 +0200 Message-ID: <20260916095243.3040533-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260916095243.3040533-1-tdevries@suse.de> References: <20260916095243.3040533-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Make gdb.python/py-rbreak.exp more readable by: - adding empty lines between groups of tests, and - reducing escaping using {} and subst_vars. --- gdb/testsuite/gdb.python/py-rbreak.exp | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp index 731ac7bbdb3..2d5fb33f666 100644 --- a/gdb/testsuite/gdb.python/py-rbreak.exp +++ b/gdb/testsuite/gdb.python/py-rbreak.exp @@ -31,7 +31,8 @@ if {![runto_main]} { } gdb_test_no_output "nosharedlibrary" -gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \ + +gdb_py_test_silent_cmd {py sl = gdb.rbreak("",minsyms=False)} \ "get all function breakpoints" 0 set min_breakpoints 11 gdb_test_multiple "py print(len(sl))" \ @@ -41,7 +42,8 @@ gdb_test_multiple "py print(len(sl))" \ gdb_assert { $n >= $min_breakpoints } $gdb_test_name } } -gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"main\.\*\",minsyms=False)" \ + +gdb_py_test_silent_cmd {py sl = gdb.rbreak("main.*",minsyms=False)} \ "get main function breakpoint" 0 gdb_test "py print(len(sl))" "1" \ "check number of returned breakpoints is 1" @@ -53,18 +55,23 @@ gdb_py_test_silent_cmd "py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle "get functions matching func.*" 0 gdb_test "py print(len(sl))" "9" \ "check number of returned breakpoints is 9" + gdb_test "py gdb.rbreak($re_func_efunc,minsyms=False,throttle=5)" \ "Number of breakpoints exceeds throttled maximum.*" \ "check throttle errors on too many breakpoints" -gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"func1\",minsyms=True)" \ + +gdb_py_test_silent_cmd {py sl = gdb.rbreak("func1",minsyms=True)} \ "including minimal symbols, get functions matching func.*" 0 gdb_test "py print(len(sl))" "2" \ "check number of returned breakpoints is 2" -gdb_py_test_silent_cmd "python sym = gdb.lookup_symbol(\"efunc1\")" \ + +gdb_py_test_silent_cmd {python sym = gdb.lookup_symbol("efunc1")} \ "find a symbol in objfile" 1 -gdb_py_test_silent_cmd "python symtab = sym\[0\].symtab" \ +gdb_py_test_silent_cmd {python symtab = sym[0].symtab} \ "get backing symbol table" 1 -gdb_py_test_silent_cmd "py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle=10,symtabs=\[symtab\])" \ +gdb_py_test_silent_cmd \ + [subst_vars \ + {py sl = gdb.rbreak($re_func_efunc,minsyms=False,throttle=10,symtabs=[symtab])}] \ "get functions matching func.* in one symtab only" 0 gdb_test "py print(len(sl))" "3" \ "check number of returned breakpoints is 3" -- 2.51.0