From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GcTzMoWzqmprvxIAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 11:19:33 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kI0KOJ5B; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AC1FD1E01F; Wed, 16 Sep 2026 11:19:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D11C51E01F for ; Wed, 16 Sep 2026 11:19:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16C0A4BAE7C8 for ; Wed, 16 Sep 2026 15:19:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16C0A4BAE7C8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kI0KOJ5B Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id B3DE84BAE7C6 for ; Wed, 16 Sep 2026 15:18:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3DE84BAE7C6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3DE84BAE7C6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789571929; cv=none; b=G/Tdb6vqlqPteCCFWPJsQCN3+1H2ynEIzpkUGUZvmLaIpI9A0fTWBuik7ILSld9Vf/O0RjUNpAn1jEvxooKxzq4gg+oKZuEGzTIwiX+y+EkykCJry8UAz0qsJ5/wR3nl7g3UYvP3vl7+5owjjI8beRbR2j6C3B5WkHxFHxKYlBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789571929; c=relaxed/simple; bh=S3Z2fQ6F3Y3EXdyUWzuBtqTSMRq7NUUmRL6UXMPObRo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w1SQvKZPcHIHgJTLVOZ55GH2oSmyNLzt6omBBqSutnB4gqLY7MR6N+iTBmGu9uJRaemK0wt+c3s1R/byBRzXKEHsKkLDRDRxykX1/BpDivrMCFmU5Ogkk0xbFOt7tfVakHwd/zScGRZ2Q/XWQaiklj3FPqLfvK+AWAWrHZ21g6s= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kI0KOJ5B reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3DE84BAE7C6 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id 6VZlxXqTAJFmF6rPMxv50L; Wed, 16 Sep 2026 15:18:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6rPLxvQG98TJY6rPLxVcVp; Wed, 16 Sep 2026 15:18:48 +0000 X-Authority-Analysis: v=2.4 cv=S9vZwJsP c=1 sm=1 tr=0 ts=6aaab358 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=zs6VHYczJzxvoGW6hTUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S3Z2fQ6F3Y3EXdyUWzuBtqTSMRq7NUUmRL6UXMPObRo=; b=kI0KOJ5B6mKzq637tJ5PdWgfL9 +Oxn5w1y5u9d1NDwVIf3vgqBCuQibye+jv785HJylXf+ycjP0QP+iNiagykP3LUwZK05UIZo8h7CO Dxn+/nSj0MRcFlF3sogK5/DUe; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:43992 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6rPL-00000002qaN-33oR; Wed, 16 Sep 2026 09:18:47 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] [gdb/testsuite] Fixes in gdb.python/py-rbreak.exp In-Reply-To: <20260916095243.3040533-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 16 Sep 2026 11:52:39 +0200") References: <20260916095243.3040533-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 16 Sep 2026 09:18:46 -0600 Message-ID: <87ik45usvd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6rPL-00000002qaN-33oR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:43992 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNvG+8xjw5HThKE7tJTqflLlqu1NOogRibVJZh3B37tsW0zijFy5pAItahHZJPPkWn/g4aCCABUOofJb4mLMp8oDJS2Sab+xGEk5fJzky3768kDaMOUt d4ux4f9SMIAKjWbtTppRNXwgxBHW9Ch9n0UyMqXzBU22JjMGP/smwjWwgpssyQgDUr0tgcG/wSGyJzHNNIzqMgo7QrGjI2ePIyk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> This series consists of 4 patches improving test-case gdb.python/py-rbreak.exp. Tom> The first makes matching more strict. Tom> The second improves readability. Tom> The third fixes an incorrect test name. Tom> The fourth speeds up the test-case by not running to main. This all seems fine to me. Approved-By: Tom Tromey For patch #1, I don't really care if test names change. In this particular case the choice of name to match was too generic, an issue we have pretty frequently when system debuginfo is installed. However your patch #4 removes this problem in a different way, so IMO the series is fine as is. thanks, Tom