From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/7.6] Fix wrong release (maybe crash GDB) in build_target_command_list
Date: Wed, 24 Apr 2013 17:48:00 -0000 [thread overview]
Message-ID: <87haiwngpr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon0RCwi1CQepWnZuuPvXUNVHXJU-UbknXaR_U3h8shUc8g@mail.gmail.com> (Hui Zhu's message of "Wed, 24 Apr 2013 21:29:29 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> 2013-04-24 Hui Zhu <hui@codesourcery.com>
Hui> * breakpoint.c (build_target_command_list): Change loc->cond_bytecode
Hui> to loc->cmd_bytecode.
Is it possible to make a test case for this?
The patch looks good.
I am curious about this code in build_target_command_list:
aexpr = parse_cmd_to_aexpr (bl->address,
loc->owner->extra_string);
loc->cmd_bytecode = aexpr;
if (!aexpr)
continue;
The "continue" seems to mean that null_command_or_parse_error will not
be set in the "parse error" case.
Also, parse_cmd_to_aexpr calls 'error' in a few spots but then in
another spot is careful not to. This seems somewhat odd.
Tom
next prev parent reply other threads:[~2013-04-24 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 15:35 Hui Zhu
2013-04-24 17:48 ` Tom Tromey [this message]
2013-04-24 19:13 ` Hui Zhu
2013-04-24 20:36 ` Tom Tromey
2013-04-25 12:49 ` Hui Zhu
2013-04-25 15:18 ` Joel Brobecker
2013-04-25 17:25 ` Hui Zhu
2013-04-24 18:58 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haiwngpr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox