From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Yao Qi <yao@codesourcery.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/7.6] Fix wrong release (maybe crash GDB) in build_target_command_list
Date: Wed, 24 Apr 2013 20:36:00 -0000 [thread overview]
Message-ID: <877gjsndpv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon1pQsGrSc-jW=083V0xfJkDOJB8b459baoU-aoHjy1-UA@mail.gmail.com> (Hui Zhu's message of "Wed, 24 Apr 2013 23:21:44 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> I tried but looks free conditions cannot crash GDB. :(
I was wondering if there could be a non-crashing reproducer.
It seems a little tricky.
I think this particular patch is ok without a test though.
Please check it in.
>> The "continue" seems to mean that null_command_or_parse_error will not
>> be set in the "parse error" case.
Hui> I think it is right, because even if one of breakpoint loc doesn't
Hui> have commands. GDB still need send other commands to target.
I think that would be an argument for removing the "break" -- but not
necessarily for keeping the "continue".
The "return" in the null_command_or_parse_error case also seems weird to
me, but I didn't think hard about it.
Tom
next prev parent reply other threads:[~2013-04-24 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 15:35 Hui Zhu
2013-04-24 17:48 ` Tom Tromey
2013-04-24 19:13 ` Hui Zhu
2013-04-24 20:36 ` Tom Tromey [this message]
2013-04-25 12:49 ` Hui Zhu
2013-04-25 15:18 ` Joel Brobecker
2013-04-25 17:25 ` Hui Zhu
2013-04-24 18:58 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gjsndpv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox