From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100821-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19879 invoked by alias); 24 Apr 2013 15:35:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19869 invoked by uid 89); 24 Apr 2013 15:35:56 -0000
X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 15:35:56 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OFZgj7024517	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 24 Apr 2013 11:35:42 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3OFZem5005496	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 24 Apr 2013 11:35:41 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches ml <gdb-patches@sourceware.org>,        Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/7.6] Fix wrong release (maybe crash GDB) in build_target_command_list
References: <CANFwon0RCwi1CQepWnZuuPvXUNVHXJU-UbknXaR_U3h8shUc8g@mail.gmail.com>	<87haiwngpr.fsf@fleche.redhat.com>	<CANFwon1pQsGrSc-jW=083V0xfJkDOJB8b459baoU-aoHjy1-UA@mail.gmail.com>
Date: Wed, 24 Apr 2013 20:36:00 -0000
In-Reply-To: <CANFwon1pQsGrSc-jW=083V0xfJkDOJB8b459baoU-aoHjy1-UA@mail.gmail.com>	(Hui Zhu's message of "Wed, 24 Apr 2013 23:21:44 +0800")
Message-ID: <877gjsndpv.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00747.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> I tried but looks free conditions cannot crash GDB.  :(

I was wondering if there could be a non-crashing reproducer.
It seems a little tricky.

I think this particular patch is ok without a test though.
Please check it in.

>> The "continue" seems to mean that null_command_or_parse_error will not
>> be set in the "parse error" case.

Hui> I think it is right, because even if one of breakpoint loc doesn't
Hui> have commands.  GDB still need send other commands to target.

I think that would be an argument for removing the "break" -- but not
necessarily for keeping the "continue".

The "return" in the null_command_or_parse_error case also seems weird to
me, but I didn't think hard about it.

Tom