From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100812-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9939 invoked by alias); 24 Apr 2013 14:31:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9928 invoked by uid 89); 24 Apr 2013 14:31:03 -0000
X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 14:31:02 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OEUwCv029156	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 24 Apr 2013 10:30:58 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3OEUuUP001204	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 24 Apr 2013 10:30:57 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,        Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/7.6] Fix wrong release (maybe crash GDB) in build_target_command_list
References: <CANFwon0RCwi1CQepWnZuuPvXUNVHXJU-UbknXaR_U3h8shUc8g@mail.gmail.com>
Date: Wed, 24 Apr 2013 17:48:00 -0000
In-Reply-To: <CANFwon0RCwi1CQepWnZuuPvXUNVHXJU-UbknXaR_U3h8shUc8g@mail.gmail.com>	(Hui Zhu's message of "Wed, 24 Apr 2013 21:29:29 +0800")
Message-ID: <87haiwngpr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00738.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> 2013-04-24  Hui Zhu  <hui@codesourcery.com>

Hui> 	* breakpoint.c (build_target_command_list): Change loc->cond_bytecode
Hui> 	to loc->cmd_bytecode.

Is it possible to make a test case for this?

The patch looks good.

I am curious about this code in build_target_command_list:

	      aexpr = parse_cmd_to_aexpr (bl->address,
					  loc->owner->extra_string);
	      loc->cmd_bytecode = aexpr;

	      if (!aexpr)
		continue;

The "continue" seems to mean that null_command_or_parse_error will not
be set in the "parse error" case.

Also, parse_cmd_to_aexpr calls 'error' in a few spots but then in
another spot is careful not to.  This seems somewhat odd.

Tom