Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Define gdb.Value(bufobj, type) constructor
Date: Mon, 18 Feb 2019 22:46:00 -0000	[thread overview]
Message-ID: <87h8d0lnq2.fsf@tromey.com> (raw)
In-Reply-To: <20190218080636.02e3847f@f29-4.lan> (Kevin Buettner's message of	"Mon, 18 Feb 2019 08:06:36 -0700")

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

FWIW I think this whole series looks quite reasonable and would be a
good addition.

Kevin> +  Py_buffer py_buf;

Elsewhere in the Python code, Py_buffer is only used conditionally on
"#ifdef IS_PY3K".  I don't know exactly why, though.  Py_buffer seems to
be in Python 2.7, maybe it wasn't in some earlier version that gdb still
supports?

I don't know whether anyone still relies on older versions of Python
(2.7 was released in 2010 so it seems plenty old at this point; after
all we require compilers released after this).

However, this seems like a decision to make consciously.
I'm not completely sure how to proceed, though one idea might be to find
the most recent Python 2.[456] compatibility patch and then asking the
author whether this support is still relevant.

thanks,
Tom


  reply	other threads:[~2019-02-18 22:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190218075816.6f67f3d9@f29-4.lan>
2019-02-18 15:03 ` [PATCH 1/4] Define unique_ptr specialization for Py_buffer Kevin Buettner
2019-02-18 15:06 ` [PATCH 2/4] Define gdb.Value(bufobj, type) constructor Kevin Buettner
2019-02-18 22:46   ` Tom Tromey [this message]
2019-02-19  0:57     ` Kevin Buettner
2019-02-19 15:19       ` Tom Tromey
2019-02-19 15:28         ` Ulrich Weigand
2019-02-19  2:41   ` Simon Marchi
2019-02-18 15:07 ` [PATCH 3/4] Add tests for " Kevin Buettner
2019-02-19  2:46   ` Simon Marchi
2019-02-18 15:09 ` [PATCH 4/4] Document two argument form of gdb.Value constructor Kevin Buettner
2019-02-18 16:13   ` Eli Zaretskii
2019-02-18 17:25     ` Kevin Buettner
2019-02-18 17:45       ` Eli Zaretskii
2019-02-19  2:48 ` [PATCH 0/4] Define gdb.Value(val, type) constructor Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8d0lnq2.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox