Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Document two argument form of gdb.Value constructor
Date: Mon, 18 Feb 2019 16:13:00 -0000	[thread overview]
Message-ID: <83tvh1jcr8.fsf@gnu.org> (raw)
In-Reply-To: <20190218080907.06fd65af@f29-4.lan> (message from Kevin Buettner	on Mon, 18 Feb 2019 08:09:07 -0700)

> Date: Mon, 18 Feb 2019 08:09:07 -0700
> From: Kevin Buettner <kevinb@redhat.com>
> 
> +@defun Value.__init__ (@var{val}, @r{[}, type @r{]})
> +This second form of the @code{gdb.Value} constructor returns a gdb
> +value of type @{type} where the value contents are taken from the

"gdb value" should be "@code{gdb.value}", right?

> +python buffer object specified by @var{val}.  The number of bytes in
> +the python buffer object must be greater than or equal to the size of
> +@var{type}.

I think elsewhere we capitalize Python.

OK with those two fixed.

Thanks.

P.S. Does this warrant a NEWS entry?


  reply	other threads:[~2019-02-18 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190218075816.6f67f3d9@f29-4.lan>
2019-02-18 15:03 ` [PATCH 1/4] Define unique_ptr specialization for Py_buffer Kevin Buettner
2019-02-18 15:06 ` [PATCH 2/4] Define gdb.Value(bufobj, type) constructor Kevin Buettner
2019-02-18 22:46   ` Tom Tromey
2019-02-19  0:57     ` Kevin Buettner
2019-02-19 15:19       ` Tom Tromey
2019-02-19 15:28         ` Ulrich Weigand
2019-02-19  2:41   ` Simon Marchi
2019-02-18 15:07 ` [PATCH 3/4] Add tests for " Kevin Buettner
2019-02-19  2:46   ` Simon Marchi
2019-02-18 15:09 ` [PATCH 4/4] Document two argument form of gdb.Value constructor Kevin Buettner
2019-02-18 16:13   ` Eli Zaretskii [this message]
2019-02-18 17:25     ` Kevin Buettner
2019-02-18 17:45       ` Eli Zaretskii
2019-02-19  2:48 ` [PATCH 0/4] Define gdb.Value(val, type) constructor Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tvh1jcr8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox