From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72938 invoked by alias); 18 Feb 2019 22:46:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72838 invoked by uid 89); 18 Feb 2019 22:46:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Feb 2019 22:46:01 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id BA85D153B31 for ; Mon, 18 Feb 2019 16:45:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vrfigAopC90onvrfigX28W; Mon, 18 Feb 2019 16:45:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5Ie1KCmKmLzb78BCEoDlieLYsFaF2yDkqP/RO9m9VgI=; b=nZ33n8CbB3uXfwCpForC6qWBbH 6zMe+D77VCAN53zs9LeYeyKdrnSVpQyF7TNIZv+OHnW2B/bbALbn8GgsIcgbaC9a5at1QdUKd2EuS oQvFRHYxSpUQwoqtvUPvdb4LC; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:40840 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gvrfi-002V1o-FZ; Mon, 18 Feb 2019 16:45:58 -0600 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Define gdb.Value(bufobj, type) constructor References: <20190218075816.6f67f3d9@f29-4.lan> <20190218080636.02e3847f@f29-4.lan> Date: Mon, 18 Feb 2019 22:46:00 -0000 In-Reply-To: <20190218080636.02e3847f@f29-4.lan> (Kevin Buettner's message of "Mon, 18 Feb 2019 08:06:36 -0700") Message-ID: <87h8d0lnq2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00291.txt.bz2 >>>>> "Kevin" == Kevin Buettner writes: FWIW I think this whole series looks quite reasonable and would be a good addition. Kevin> + Py_buffer py_buf; Elsewhere in the Python code, Py_buffer is only used conditionally on "#ifdef IS_PY3K". I don't know exactly why, though. Py_buffer seems to be in Python 2.7, maybe it wasn't in some earlier version that gdb still supports? I don't know whether anyone still relies on older versions of Python (2.7 was released in 2010 so it seems plenty old at this point; after all we require compilers released after this). However, this seems like a decision to make consciously. I'm not completely sure how to proceed, though one idea might be to find the most recent Python 2.[456] compatibility patch and then asking the author whether this support is still relevant. thanks, Tom