From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/testsuite: remove trailing \r from rust_llvm_version result
Date: Tue, 04 Jun 2024 07:51:56 -0600 [thread overview]
Message-ID: <87h6e8q0hv.fsf@tromey.com> (raw)
In-Reply-To: <da39fb3a6cb732e09ef946d409eaa2cbbbbdaf7c.1717438458.git.aburgess@redhat.com> (Andrew Burgess's message of "Mon, 3 Jun 2024 19:16:52 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
I saw your note about ignoring this series but...
Andrew> This commit makes two fixes:
Andrew> 1. I use regsub to convert all '\r\n' sequences to '\n'; now when we
Andrew> split on '\n' the lines will not end in '\r'.
Andrew> 2. Within the loop over lines block I now check the line contents
Andrew> rather than the unsplit full output; now we capture a value
Andrew> without a trailing '\r'.
... I think this is worthwhile on its own.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-06-04 13:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 18:16 [PATCH 0/4] gdb/testsuite: remove can_spawn_for_attach_1 Andrew Burgess
2024-06-03 18:16 ` [PATCH 1/4] gdb/testsuite: remove trailing \r from rust_llvm_version result Andrew Burgess
2024-06-04 13:51 ` Tom Tromey [this message]
2024-06-05 9:20 ` Andrew Burgess
2024-06-03 18:16 ` [PATCH 2/4] gdb/testsuite: improve with_override Andrew Burgess
2024-06-03 18:16 ` [PATCH 3/4] gdb/testsuite: restructure gdb_data_cache (lib/cache.exp) Andrew Burgess
2024-06-03 18:16 ` [PATCH 4/4] gdb/testsuite: track if a caching proc calls gdb_exit or not Andrew Burgess
2024-08-07 6:05 ` Luis Machado
2024-08-07 9:16 ` Andrew Burgess
2024-08-07 10:00 ` Andrew Burgess
2024-08-07 10:08 ` Luis Machado
2024-08-07 10:12 ` Luis Machado
2024-08-07 12:45 ` Andrew Burgess
2024-08-07 14:31 ` Andrew Burgess
2024-08-07 18:35 ` Luis Machado
2024-08-08 10:20 ` Luis Machado
2024-08-08 10:50 ` Luis Machado
2024-08-08 11:08 ` Luis Machado
2024-08-08 14:50 ` Andrew Burgess
2024-08-09 11:29 ` Luis Machado
2024-08-13 16:30 ` Andrew Burgess
2024-08-14 13:06 ` Luis Machado
2024-08-14 17:00 ` Andrew Burgess
2024-08-15 6:03 ` Luis Machado
2024-08-20 15:25 ` Andrew Burgess
2024-06-04 9:06 ` [PATCH 0/4] gdb/testsuite: remove can_spawn_for_attach_1 Andrew Burgess
2024-06-05 13:27 ` [PATCHv2 0/2] " Andrew Burgess
2024-06-05 13:27 ` [PATCHv2 1/2] gdb/testsuite: restructure gdb_data_cache (lib/cache.exp) Andrew Burgess
2024-06-05 13:27 ` [PATCHv2 2/2] gdb/testsuite: track if a caching proc calls gdb_exit or not Andrew Burgess
2024-07-28 8:54 ` [PUSHED 0/2] gdb/testsuite: remove can_spawn_for_attach_1 Andrew Burgess
2024-07-28 8:54 ` [PUSHED 1/2] gdb/testsuite: restructure gdb_data_cache (lib/cache.exp) Andrew Burgess
2024-07-28 8:54 ` [PUSHED 2/2] gdb/testsuite: track if a caching proc calls gdb_exit or not Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6e8q0hv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox