Re: [PATCH] gdb: fix handling of raw ANSI escape sequences printed from Python

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Prior to this commit GDB would always forward any ANSI escape
Andrew> sequences directly to the output stream, but this meant that GDB
Andrew> didn't know which style was currently in effect.

Andrew> The above commit changed GDB so that we would parse the ANSI escape
Andrew> sequence, and then apply it to the output stream, this allowed GDB to
Andrew> track which style was in use, which in turn meant that GDB could
Andrew> correctly suspend the style and reapply it when the pager was
Andrew> activated.

I think I probably didn't fully understand this patch in retrospect.

If the pager is already parsing escape sequences and reacting
accordingly, then I wonder if there's any need at all for
ui_file::emit_style_escape.

Andrew> This can be easily fixed by starting from the current style, rather
Andrew> than the default style.

Approved-By: Tom Tromey <tom@tromey.com>

Tom