Re: [PATCH] gdb: fix handling of raw ANSI escape sequences printed from Python

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> Prior to this commit GDB would always forward any ANSI escape
> Andrew> sequences directly to the output stream, but this meant that GDB
> Andrew> didn't know which style was currently in effect.
>
> Andrew> The above commit changed GDB so that we would parse the ANSI escape
> Andrew> sequence, and then apply it to the output stream, this allowed GDB to
> Andrew> track which style was in use, which in turn meant that GDB could
> Andrew> correctly suspend the style and reapply it when the pager was
> Andrew> activated.
>
> I think I probably didn't fully understand this patch in retrospect.
>
> If the pager is already parsing escape sequences and reacting
> accordingly, then I wonder if there's any need at all for
> ui_file::emit_style_escape.

I'm not entirely sure what you mean here, but I do wonder if the
m_applied_style should be moved from ui_file, and ui_file should become
a pure interface class.

It's kind-of weird that the pager class ends up tracking some state
within its grandparent's ui_file::m_applied_style, but then it also
needs to track and mirror some state from within
m_stream::m_applied_state.

I wonder if there should be a new class which inherits from ui_file
which actually implements styling, and would be used for the basic
streams.

Then for pager, more of the state would actually reside within that
class, which I think would simplify the code slightly.

>
> Andrew> This can be easily fixed by starting from the current style, rather
> Andrew> than the default style.
>
> Approved-By: Tom Tromey <tom@tromey.com>

I'm going to check this in to both master, and the 17 branch.

Thanks,
Andrew