From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /lk/MkwPaWkl8gQAWB0awg (envelope-from ) for ; Thu, 15 Jan 2026 11:01:16 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k57ct18e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BE3C71E070; Thu, 15 Jan 2026 11:01:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 442B91E070 for ; Thu, 15 Jan 2026 11:01:16 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A70AE4BA23DE for ; Thu, 15 Jan 2026 16:01:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A70AE4BA23DE Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k57ct18e Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id D37D84BA23C1 for ; Thu, 15 Jan 2026 16:00:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D37D84BA23C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D37D84BA23C1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768492823; cv=none; b=AyUcIhmgv2lMnBsUNmsdBd1lO01Z6bOmvgvBs+2KS67Ew5Z1exbs9p+sk1IjNqWRhoATjxAjMXM4RdlA3RwI6PXZpU1eJj+K6CbNAkILC5556dt36zp+rCSSsK3k3ykuzG8YmIvNGnJynj5irRC6Sow9JwMBNEBsB9bq/iWDyXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768492823; c=relaxed/simple; bh=uPo23g//xg2vEd5yDJcHcwH8UJMjR706h9pzDG/TmTQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=knXbWRYOYLdfAyYjmG20xJHrysJBuAvQ1MqTPVX+rZ6YKgorcY8RC9Gy26aElG/l5WMk68w2FcVpJvn4LOh5vZYehYnCrm8BYB/GD8VTqnkKkzS6a0hSbSW8c6gA62BLtfvYnF9tjuVvT7BUjKuountyUM50lniue+9l89ijD2I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D37D84BA23C1 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id gNhIvNRheCxrGgPlnvfc8A; Thu, 15 Jan 2026 16:00:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id gPlnvFM1PV6WMgPlnvzzb5; Thu, 15 Jan 2026 16:00:23 +0000 X-Authority-Analysis: v=2.4 cv=E//Npbdl c=1 sm=1 tr=0 ts=69690f17 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=F4UB25BJmeRrd46-x5YA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uPo23g//xg2vEd5yDJcHcwH8UJMjR706h9pzDG/TmTQ=; b=k57ct18evA3mhD1+RUyE7PGnZo ZWzGtQlxz1sKEnC6KCbNm0BQjYgDMMP92v0gzpr1pU1kntK2DwAA8z6zwQD1OSkiyBPEIlk+5pxox PZZo2l/U7xnRmD7n94gm762Uj; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:47600 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vgPlm-00000002Duh-3HC9; Thu, 15 Jan 2026 09:00:22 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Patryk Sondej Subject: Re: [PATCH] gdb: fix handling of raw ANSI escape sequences printed from Python In-Reply-To: <2b96eaf47bcb84cf955f4e59ec34c8582b5ceb81.1768475197.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 15 Jan 2026 11:06:48 +0000") References: <2b96eaf47bcb84cf955f4e59ec34c8582b5ceb81.1768475197.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 15 Jan 2026 09:00:21 -0700 Message-ID: <87h5smg92i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vgPlm-00000002Duh-3HC9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:47600 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNsvDN72tnqD11XwaQDQF8KxsNl/rJAolxZ5fkGxvDOG2a6whvlw44QBcb6IpGsHdH07/Rp24P9vyKXLWROmKJHr7vhpwqH7EjwrPSSv5NFKQhRKs7QM lEJ3GcBLTMR5QX6G0L1Cjt/vpZmZ3KBSb0QG+WelRd9QfPwM3UzfoltWXZHXO+qwyxY69VtZ1MEaTcc2sMDyLcRi34zBFCPWzDU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Prior to this commit GDB would always forward any ANSI escape Andrew> sequences directly to the output stream, but this meant that GDB Andrew> didn't know which style was currently in effect. Andrew> The above commit changed GDB so that we would parse the ANSI escape Andrew> sequence, and then apply it to the output stream, this allowed GDB to Andrew> track which style was in use, which in turn meant that GDB could Andrew> correctly suspend the style and reapply it when the pager was Andrew> activated. I think I probably didn't fully understand this patch in retrospect. If the pager is already parsing escape sequences and reacting accordingly, then I wonder if there's any need at all for ui_file::emit_style_escape. Andrew> This can be easily fixed by starting from the current style, rather Andrew> than the default style. Approved-By: Tom Tromey Tom