From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, <gdb-patches@sourceware.org>
Subject: Re: [committed] Remove a redundant condition check in tic6x-linux-tdep.c
Date: Wed, 05 Dec 2012 18:30:00 -0000 [thread overview]
Message-ID: <87fw3ks672.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50B8BE62.3040602@codesourcery.com> (Yao Qi's message of "Fri, 30 Nov 2012 22:10:42 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> This patch is to change function tic6x_register_sigcontext_offset,
Yao> which is to get the input REGNUM, and return the offset of
Yao> corresponding register in 'struct sigcontext'. So -1 means 'all
Yao> registers' doesn't apply here.
Yao> Thank for reminding me this, I don't know -1 means 'all registers' before.
I suppose it is possible to change all the unsigned ints to ints in that
spot, but overall I think it is clearer with unsigned.
Tom
prev parent reply other threads:[~2012-12-05 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 7:35 Yao Qi
2012-11-30 12:22 ` Mark Kettenis
2012-11-30 14:11 ` Yao Qi
2012-12-05 18:30 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw3ks672.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox