From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [committed] Remove a redundant condition check in tic6x-linux-tdep.c
Date: Fri, 30 Nov 2012 12:22:00 -0000 [thread overview]
Message-ID: <201211301222.qAUCMSLI011405@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1354260922-13995-1-git-send-email-yao@codesourcery.com> (message from Yao Qi on Fri, 30 Nov 2012 15:35:22 +0800)
> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 30 Nov 2012 15:35:22 +0800
>
> Hi,
> When gdb is configured as target=tic6x-uclinux, and compiled with clang,
> I get this warning:
>
> gdb/tic6x-linux-tdep.c:66:19: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare]
>
> It is redundant to check 'REGNUM >= 0' as it is unsigned. The
> following patch is to fix it. Committed.
Hmm, well, perhaps the regnum variable should just be made signed.
That's typically what we use for register numbers, since -1 has the
special meaning of "all registers"/
next prev parent reply other threads:[~2012-11-30 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 7:35 Yao Qi
2012-11-30 12:22 ` Mark Kettenis [this message]
2012-11-30 14:11 ` Yao Qi
2012-12-05 18:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211301222.qAUCMSLI011405@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox