From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5676 invoked by alias); 5 Dec 2012 18:30:06 -0000 Received: (qmail 5522 invoked by uid 22791); 5 Dec 2012 18:30:02 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 18:29:56 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB5ITs2J001540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Dec 2012 13:29:55 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB5ITriu016089 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 5 Dec 2012 13:29:54 -0500 From: Tom Tromey To: Yao Qi Cc: Mark Kettenis , Subject: Re: [committed] Remove a redundant condition check in tic6x-linux-tdep.c References: <1354260922-13995-1-git-send-email-yao@codesourcery.com> <201211301222.qAUCMSLI011405@glazunov.sibelius.xs4all.nl> <50B8BE62.3040602@codesourcery.com> Date: Wed, 05 Dec 2012 18:30:00 -0000 In-Reply-To: <50B8BE62.3040602@codesourcery.com> (Yao Qi's message of "Fri, 30 Nov 2012 22:10:42 +0800") Message-ID: <87fw3ks672.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00088.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> This patch is to change function tic6x_register_sigcontext_offset, Yao> which is to get the input REGNUM, and return the offset of Yao> corresponding register in 'struct sigcontext'. So -1 means 'all Yao> registers' doesn't apply here. Yao> Thank for reminding me this, I don't know -1 means 'all registers' before. I suppose it is possible to change all the unsigned ints to ints in that spot, but overall I think it is clearer with unsigned. Tom