Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
	       "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFC: fix PR backtrace/15558
Date: Wed, 16 Apr 2014 20:03:00 -0000	[thread overview]
Message-ID: <87fvldnit4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <534C6BDD.2090805@redhat.com> (Pedro Alves's message of "Tue, 15	Apr 2014 00:14:37 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> See patch below.  I've simplified your test a bit, and added a test
Pedro> that doesn't depend on Python, to the existing gdb.opt/inline-bt.exp.

Thanks.

Pedro> Not sure.  I guess Python code might want to be implementing some
Pedro> new frame-related CLI command, where the limits make sense.  Maybe
Pedro> Python should really have access to both variants, somehow?

I was thinking perhaps new methods on the python frame object.

Pedro> 	PR backtrace/15558
Pedro> 	* gdb.opt/inline-bt.exp: Test backtracing from an inline function
Pedro> 	with a backtrace limit.
Pedro> 	* py-frame-inline.exp: Test running to an inline function with a
Pedro> 	bactrace limit, and printing the newest frame.

Typo in "backtrace" on the last line.

The patch looks good but the ChangeLog has a missing directory name and
doesn't mention :

>  gdb/testsuite/gdb.python/py-frame-inline.c   |  4 +++-

Tom


  reply	other threads:[~2014-04-16 20:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 19:35 Tom Tromey
2013-06-06 23:42 ` Pedro Alves
2013-06-21 21:21   ` Tom Tromey
2014-04-10 23:56     ` Andrew Pinski
2014-04-14 18:06       ` Tom Tromey
2014-04-14 18:42         ` Pedro Alves
2014-04-14 18:52           ` Tom Tromey
2014-04-14 23:14             ` Pedro Alves
2014-04-16 20:03               ` Tom Tromey [this message]
2014-04-18  9:43                 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvldnit4.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox