From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFC: fix PR backtrace/15558
Date: Mon, 14 Apr 2014 18:52:00 -0000 [thread overview]
Message-ID: <87tx9vpwvb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <534C2C19.1010503@redhat.com> (Pedro Alves's message of "Mon, 14 Apr 2014 19:42:33 +0100")
Tom> I never got back to fixing it according to Pedro's review.
Tom> As I recall it isn't entirely trivial because for a good fix one would
Tom> need to expose some new Python methods for use by the frame filter code.
Pedro> Hmm. Not sure what you're thinking of.
There's a good chance I'm confusing it with some other approach I'd
considered.
Pedro> We discussed auditing all
Pedro> get_prev_frame uses and see if they are better replaced by
Pedro> get_prev_frame_1, but I don't think that should hold back
Pedro> fixing the inline frame unwinder.
Ok.
I think what I was thinking is that if one starts this change, then the
question arises: which should the Python unwinder call? Calling the
user-facing one is plainly incorrect. But, calling the internal one is
also incorrect, as some termination conditions may be skipped.
Perhaps this only applies if we move all the checks into get_prev_frame_1.
I don't recall whether that was part of the plan or not.
Tom
next prev parent reply other threads:[~2014-04-14 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 19:35 Tom Tromey
2013-06-06 23:42 ` Pedro Alves
2013-06-21 21:21 ` Tom Tromey
2014-04-10 23:56 ` Andrew Pinski
2014-04-14 18:06 ` Tom Tromey
2014-04-14 18:42 ` Pedro Alves
2014-04-14 18:52 ` Tom Tromey [this message]
2014-04-14 23:14 ` Pedro Alves
2014-04-16 20:03 ` Tom Tromey
2014-04-18 9:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx9vpwvb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox