From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23810 invoked by alias); 16 Apr 2014 20:03:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23801 invoked by uid 89); 16 Apr 2014 20:03:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Apr 2014 20:03:23 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3GK3LSw031106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Apr 2014 16:03:21 -0400 Received: from barimba (ovpn-113-119.phx2.redhat.com [10.3.113.119]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3GK3J4e031031 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 16 Apr 2014 16:03:20 -0400 From: Tom Tromey To: Pedro Alves Cc: Andrew Pinski , "gdb-patches\@sourceware.org" Subject: Re: RFC: fix PR backtrace/15558 References: <87li6nghhz.fsf@fleche.redhat.com> <51B11E66.70102@redhat.com> <87mwqjw613.fsf@fleche.redhat.com> <87ha5vrdki.fsf@fleche.redhat.com> <534C2C19.1010503@redhat.com> <87tx9vpwvb.fsf@fleche.redhat.com> <534C6BDD.2090805@redhat.com> Date: Wed, 16 Apr 2014 20:03:00 -0000 In-Reply-To: <534C6BDD.2090805@redhat.com> (Pedro Alves's message of "Tue, 15 Apr 2014 00:14:37 +0100") Message-ID: <87fvldnit4.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-04/txt/msg00331.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> See patch below. I've simplified your test a bit, and added a test Pedro> that doesn't depend on Python, to the existing gdb.opt/inline-bt.exp. Thanks. Pedro> Not sure. I guess Python code might want to be implementing some Pedro> new frame-related CLI command, where the limits make sense. Maybe Pedro> Python should really have access to both variants, somehow? I was thinking perhaps new methods on the python frame object. Pedro> PR backtrace/15558 Pedro> * gdb.opt/inline-bt.exp: Test backtracing from an inline function Pedro> with a backtrace limit. Pedro> * py-frame-inline.exp: Test running to an inline function with a Pedro> bactrace limit, and printing the newest frame. Typo in "backtrace" on the last line. The patch looks good but the ChangeLog has a missing directory name and doesn't mention : > gdb/testsuite/gdb.python/py-frame-inline.c | 4 +++- Tom