Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add test for global variable that is nested by another DSO
Date: Wed, 17 Sep 2014 02:59:00 -0000	[thread overview]
Message-ID: <87fvfrosut.fsf@redhat.com> (raw)
In-Reply-To: <20140917002135.GQ4871@adacore.com> (Joel Brobecker's message of	"Tue, 16 Sep 2014 17:21:35 -0700")

On Tuesday, September 16 2014, Joel Brobecker wrote:

>> > gdb/testsuite/ChangeLog:
>> > 2014-09-04  Sergio Durigan Junior  <sergiodj@redhat.com>
>> >
>> > 	* gdb.base/global-var-nested-by-dso-solib1.c: New file.
>> > 	* gdb.base/global-var-nested-by-dso-solib2.c: Likewise.
>> > 	* gdb.base/global-var-nested-by-dso.c: Likewise.
>> > 	* gdb.base/global-var-nested-by-dso.exp: Likewise.
>
> Sorry it took so long to review this patch. This looks good to me,
> so go ahead and commit.

Thanks a lot, Joel :-).

Pushed:

  <https://sourceware.org/ml/gdb-cvs/2014-09/msg00075.html>
  <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a594760181bc3859df1f19e3cca361ad7d031bd9>

> Thank you also for writing testcases. These are not always our
> favorite past-time, but their usefulness can never be overstated.

My pleasure :-).

Cheers,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


      reply	other threads:[~2014-09-17  2:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 21:32 Sergio Durigan Junior
2014-09-16 23:45 ` Sergio Durigan Junior
2014-09-17  0:21   ` Joel Brobecker
2014-09-17  2:59     ` Sergio Durigan Junior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvfrosut.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox