From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10094 invoked by alias); 17 Sep 2014 02:59:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10069 invoked by uid 89); 17 Sep 2014 02:58:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Sep 2014 02:58:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8H2wpe6001113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Sep 2014 22:58:51 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8H2woAn005392 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 16 Sep 2014 22:58:50 -0400 From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches Subject: Re: [PATCH] Add test for global variable that is nested by another DSO References: <1409866373-16413-1-git-send-email-sergiodj@redhat.com> <87ioknqgdh.fsf@redhat.com> <20140917002135.GQ4871@adacore.com> X-URL: http://www.redhat.com Date: Wed, 17 Sep 2014 02:59:00 -0000 In-Reply-To: <20140917002135.GQ4871@adacore.com> (Joel Brobecker's message of "Tue, 16 Sep 2014 17:21:35 -0700") Message-ID: <87fvfrosut.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00564.txt.bz2 On Tuesday, September 16 2014, Joel Brobecker wrote: >> > gdb/testsuite/ChangeLog: >> > 2014-09-04 Sergio Durigan Junior >> > >> > * gdb.base/global-var-nested-by-dso-solib1.c: New file. >> > * gdb.base/global-var-nested-by-dso-solib2.c: Likewise. >> > * gdb.base/global-var-nested-by-dso.c: Likewise. >> > * gdb.base/global-var-nested-by-dso.exp: Likewise. > > Sorry it took so long to review this patch. This looks good to me, > so go ahead and commit. Thanks a lot, Joel :-). Pushed: > Thank you also for writing testcases. These are not always our > favorite past-time, but their usefulness can never be overstated. My pleasure :-). Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/