From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add test for global variable that is nested by another DSO
Date: Wed, 17 Sep 2014 00:21:00 -0000 [thread overview]
Message-ID: <20140917002135.GQ4871@adacore.com> (raw)
In-Reply-To: <87ioknqgdh.fsf@redhat.com>
> > gdb/testsuite/ChangeLog:
> > 2014-09-04 Sergio Durigan Junior <sergiodj@redhat.com>
> >
> > * gdb.base/global-var-nested-by-dso-solib1.c: New file.
> > * gdb.base/global-var-nested-by-dso-solib2.c: Likewise.
> > * gdb.base/global-var-nested-by-dso.c: Likewise.
> > * gdb.base/global-var-nested-by-dso.exp: Likewise.
Sorry it took so long to review this patch. This looks good to me,
so go ahead and commit.
Thank you also for writing testcases. These are not always our
favorite past-time, but their usefulness can never be overstated.
Thank you,
--
Joel
next prev parent reply other threads:[~2014-09-17 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:32 Sergio Durigan Junior
2014-09-16 23:45 ` Sergio Durigan Junior
2014-09-17 0:21 ` Joel Brobecker [this message]
2014-09-17 2:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917002135.GQ4871@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox