From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3691 invoked by alias); 17 Sep 2014 00:21:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3681 invoked by uid 89); 17 Sep 2014 00:21:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 17 Sep 2014 00:21:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C344F116136; Tue, 16 Sep 2014 20:21:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yF5+WbEbS-JN; Tue, 16 Sep 2014 20:21:35 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9CFA2116127; Tue, 16 Sep 2014 20:21:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 229D340E17; Tue, 16 Sep 2014 17:21:35 -0700 (PDT) Date: Wed, 17 Sep 2014 00:21:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] Add test for global variable that is nested by another DSO Message-ID: <20140917002135.GQ4871@adacore.com> References: <1409866373-16413-1-git-send-email-sergiodj@redhat.com> <87ioknqgdh.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ioknqgdh.fsf@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00561.txt.bz2 > > gdb/testsuite/ChangeLog: > > 2014-09-04 Sergio Durigan Junior > > > > * gdb.base/global-var-nested-by-dso-solib1.c: New file. > > * gdb.base/global-var-nested-by-dso-solib2.c: Likewise. > > * gdb.base/global-var-nested-by-dso.c: Likewise. > > * gdb.base/global-var-nested-by-dso.exp: Likewise. Sorry it took so long to review this patch. This looks good to me, so go ahead and commit. Thank you also for writing testcases. These are not always our favorite past-time, but their usefulness can never be overstated. Thank you, -- Joel