[COMMITTED PATCH] Move clear_symtab_users, deduce_language_from_filename decls to better place

[COMMITTED PATCH] Move clear_symtab_users, deduce_language_from_filename decls to better place

[Doug Evans]

Hi.

Just some minor cleanup I noticed while hacking on pr 17936.

2015-02-06  Doug Evans  <dje@google.com>

	* symtab.h (clear_symtab_users, deduce_language_from_filename): Move
	* symfile.h (clear_symtab_users, deduce_language_from_filename): ...
	to here.

diff --git a/gdb/symfile.h b/gdb/symfile.h
index d5ae4ad..a22ee04 100644
--- a/gdb/symfile.h
+++ b/gdb/symfile.h
@@ -434,6 +434,10 @@ extern void add_compunit_symtab_to_objfile (struct compunit_symtab *cu);
 
 extern void add_symtab_fns (enum bfd_flavour flavour, const struct sym_fns *);
 
+extern void clear_symtab_users (int add_flags);
+
+extern enum language deduce_language_from_filename (const char *);
+
 /* This enum encodes bit-flags passed as ADD_FLAGS parameter to
    symbol_file_add, etc.  */
 
diff --git a/gdb/symtab.h b/gdb/symtab.h
index d1d2147..0eb3a5b 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -1416,7 +1416,7 @@ extern int find_line_pc_range (struct symtab_and_line, CORE_ADDR *,
 
 extern void resolve_sal_pc (struct symtab_and_line *);
 
-/* Symbol-reading stuff in symfile.c and solib.c.  */
+/* solib.c */
 
 extern void clear_solib (void);
 
@@ -1474,12 +1474,6 @@ extern struct symtab_and_line find_function_start_sal (struct symbol *sym,
 
 extern void skip_prologue_sal (struct symtab_and_line *);
 
-/* symfile.c */
-
-extern void clear_symtab_users (int add_flags);
-
-extern enum language deduce_language_from_filename (const char *);
-
 /* symtab.c */
 
 extern CORE_ADDR skip_prologue_using_sal (struct gdbarch *gdbarch,

Re: [COMMITTED PATCH] Move clear_symtab_users, deduce_language_from_filename decls to better place

[Sergio Durigan Junior]

On Friday, February 06 2015, Doug Evans wrote:

> Hi.
>
> Just some minor cleanup I noticed while hacking on pr 17936.
>
> 2015-02-06  Doug Evans  <dje@google.com>
>
> 	* symtab.h (clear_symtab_users, deduce_language_from_filename): Move
> 	* symfile.h (clear_symtab_users, deduce_language_from_filename): ...
> 	to here.

Hey Doug,

Your commit fails to build on Fedora 21:

  <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/172/steps/compile%20gdb/logs/stdio>

Cheers,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: [COMMITTED PATCH] Move clear_symtab_users, deduce_language_from_filename decls to better place

[Doug Evans]

On Fri, Feb 6, 2015 at 12:07 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
>
> On Friday, February 06 2015, Doug Evans wrote:
>
> > Hi.
> >
> > Just some minor cleanup I noticed while hacking on pr 17936.
> >
> > 2015-02-06  Doug Evans  <dje@google.com>
> >
> >       * symtab.h (clear_symtab_users, deduce_language_from_filename): Move
> >       * symfile.h (clear_symtab_users, deduce_language_from_filename): ...
> >       to here.
>
> Hey Doug,
>
> Your commit fails to build on Fedora 21:
>
>   <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/172/steps/compile%20gdb/logs/stdio>
>
> Cheers,


Bleah.  Fixed, thanks.
Verified builds with --enable-targets=all.

2015-02-06  Doug Evans  <dje@google.com>

        * remote-m32r-sdi.c: Include symfile.h.

diff --git a/gdb/remote-m32r-sdi.c b/gdb/remote-m32r-sdi.c
index 6052386..c55b75c 100644
--- a/gdb/remote-m32r-sdi.c
+++ b/gdb/remote-m32r-sdi.c
@@ -40,7 +40,7 @@
 #include <time.h>
 #include "gdb_bfd.h"
 #include "cli/cli-utils.h"
-
+#include "symfile.h"
 #include "serial.h"

 /* Descriptor for I/O to remote machine.  */