From: Doug Evans <dje@google.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [COMMITTED PATCH] Move clear_symtab_users, deduce_language_from_filename decls to better place
Date: Fri, 06 Feb 2015 20:20:00 -0000 [thread overview]
Message-ID: <CADPb22TZHqqxejvd7CNHHgiOC1BX73BhV3y95kQEtvW4p_7bHw@mail.gmail.com> (raw)
In-Reply-To: <87fvai7qic.fsf@redhat.com>
On Fri, Feb 6, 2015 at 12:07 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
>
> On Friday, February 06 2015, Doug Evans wrote:
>
> > Hi.
> >
> > Just some minor cleanup I noticed while hacking on pr 17936.
> >
> > 2015-02-06 Doug Evans <dje@google.com>
> >
> > * symtab.h (clear_symtab_users, deduce_language_from_filename): Move
> > * symfile.h (clear_symtab_users, deduce_language_from_filename): ...
> > to here.
>
> Hey Doug,
>
> Your commit fails to build on Fedora 21:
>
> <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/172/steps/compile%20gdb/logs/stdio>
>
> Cheers,
Bleah. Fixed, thanks.
Verified builds with --enable-targets=all.
2015-02-06 Doug Evans <dje@google.com>
* remote-m32r-sdi.c: Include symfile.h.
diff --git a/gdb/remote-m32r-sdi.c b/gdb/remote-m32r-sdi.c
index 6052386..c55b75c 100644
--- a/gdb/remote-m32r-sdi.c
+++ b/gdb/remote-m32r-sdi.c
@@ -40,7 +40,7 @@
#include <time.h>
#include "gdb_bfd.h"
#include "cli/cli-utils.h"
-
+#include "symfile.h"
#include "serial.h"
/* Descriptor for I/O to remote machine. */
prev parent reply other threads:[~2015-02-06 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 19:34 Doug Evans
2015-02-06 20:07 ` Sergio Durigan Junior
2015-02-06 20:20 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TZHqqxejvd7CNHHgiOC1BX73BhV3y95kQEtvW4p_7bHw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox