Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: unconditionally define _initialize_string_view_selftests
Date: Fri, 15 Mar 2019 14:24:00 -0000	[thread overview]
Message-ID: <87ftrob4ha.fsf@tromey.com> (raw)
In-Reply-To: <20190314222828.28798-1-slyfox@gentoo.org> (Sergei Trofimovich's	message of "Thu, 14 Mar 2019 22:28:28 +0000")

>>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:

Sergei> The build failure was noticed by Helmut Jarausch in
Sergei> https://bugs.gentoo.org/680232:
Sergei>     $ ./configure CXXFLAGS='-std=c++17 -Os'
Sergei>     ...
Sergei>       CXXLD  gdb
Sergei>     ld: init.o: in function `initialize_all_files()':
Sergei>     init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()'

Sergei> It happens because '_initialize_string_view_selftests()' is
Sergei> conditionally defined based on C++ default.

Sergei> The change defines '_initialize_string_view_selftests()'
Sergei> unconditionally and leaves implementation a no-op on c++17
Sergei> compilers.

Thank you.  This is OK with a ChangeLog entry.
Let me know if you need me to check it in for you.

thanks,
Tom


  reply	other threads:[~2019-03-15 14:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 22:28 Sergei Trofimovich
2019-03-15 14:24 ` Tom Tromey [this message]
2019-03-17 22:20   ` Sergei Trofimovich
2019-03-17 22:28     ` [PATCH v2] " Sergei Trofimovich
2019-03-18  4:02       ` Sergio Durigan Junior
2019-03-18  3:55     ` [PATCH] " Sergio Durigan Junior
2019-03-18 16:00       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftrob4ha.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=slyfox@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox