From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102587 invoked by alias); 15 Mar 2019 14:24:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102393 invoked by uid 89); 15 Mar 2019 14:24:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:852 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Mar 2019 14:24:39 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 3F4B9400D1866 for ; Fri, 15 Mar 2019 09:24:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4nkwhUB0S90on4nkwhlj2H; Fri, 15 Mar 2019 09:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jpGnxE1g2+g3daQDR5/rT7GnLBGPLZBSv6i0EQ7q6Tw=; b=rmWeM9DIxNdcCCFv/gwH8OQStp bxB/ps1RQJ8yxy/+IIACcgD3hSiyH50jbdQBgk1oHr5p/idrCZa6D6j4d1WMJ5YOj4FkvITIqhdGI G6bfTK5M2N0OcLUpWKWQlhs4B; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:49032 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h4nkw-000E5E-9r; Fri, 15 Mar 2019 09:24:18 -0500 From: Tom Tromey To: Sergei Trofimovich Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: unconditionally define _initialize_string_view_selftests References: <20190314222828.28798-1-slyfox@gentoo.org> Date: Fri, 15 Mar 2019 14:24:00 -0000 In-Reply-To: <20190314222828.28798-1-slyfox@gentoo.org> (Sergei Trofimovich's message of "Thu, 14 Mar 2019 22:28:28 +0000") Message-ID: <87ftrob4ha.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00315.txt.bz2 >>>>> "Sergei" == Sergei Trofimovich writes: Sergei> The build failure was noticed by Helmut Jarausch in Sergei> https://bugs.gentoo.org/680232: Sergei> $ ./configure CXXFLAGS='-std=c++17 -Os' Sergei> ... Sergei> CXXLD gdb Sergei> ld: init.o: in function `initialize_all_files()': Sergei> init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()' Sergei> It happens because '_initialize_string_view_selftests()' is Sergei> conditionally defined based on C++ default. Sergei> The change defines '_initialize_string_view_selftests()' Sergei> unconditionally and leaves implementation a no-op on c++17 Sergei> compilers. Thank you. This is OK with a ChangeLog entry. Let me know if you need me to check it in for you. thanks, Tom