From: Sergei Trofimovich <slyfox@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: unconditionally define _initialize_string_view_selftests
Date: Sun, 17 Mar 2019 22:20:00 -0000 [thread overview]
Message-ID: <20190317222004.0afa508d@sf> (raw)
In-Reply-To: <87ftrob4ha.fsf@tromey.com>
On Fri, 15 Mar 2019 08:24:17 -0600
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:
>
> Sergei> The build failure was noticed by Helmut Jarausch in
> Sergei> https://bugs.gentoo.org/680232:
> Sergei> $ ./configure CXXFLAGS='-std=c++17 -Os'
> Sergei> ...
> Sergei> CXXLD gdb
> Sergei> ld: init.o: in function `initialize_all_files()':
> Sergei> init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()'
>
> Sergei> It happens because '_initialize_string_view_selftests()' is
> Sergei> conditionally defined based on C++ default.
>
> Sergei> The change defines '_initialize_string_view_selftests()'
> Sergei> unconditionally and leaves implementation a no-op on c++17
> Sergei> compilers.
>
> Thank you. This is OK with a ChangeLog entry.
> Let me know if you need me to check it in for you.
Thank you for the quick review! Yes, I need someone to check the
change in for me. Should I indicate it the patch email next time?
I'll send a follow-up v2 with ChangeLog added and author email
matching the company which has agreement already signed with FSF.
--
Sergei
next prev parent reply other threads:[~2019-03-17 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 22:28 Sergei Trofimovich
2019-03-15 14:24 ` Tom Tromey
2019-03-17 22:20 ` Sergei Trofimovich [this message]
2019-03-17 22:28 ` [PATCH v2] " Sergei Trofimovich
2019-03-18 4:02 ` Sergio Durigan Junior
2019-03-18 3:55 ` [PATCH] " Sergio Durigan Junior
2019-03-18 16:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317222004.0afa508d@sf \
--to=slyfox@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox