From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104094 invoked by alias); 17 Mar 2019 22:20:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104086 invoked by uid 89); 17 Mar 2019 22:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=FSF, H*i:sk:87ftrob, fsf, H*f:sk:87ftrob X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 22:20:23 +0000 Received: from sf (trofi-1-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:a0f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 8231E335D24; Sun, 17 Mar 2019 22:20:21 +0000 (UTC) Date: Sun, 17 Mar 2019 22:20:00 -0000 From: Sergei Trofimovich To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: unconditionally define _initialize_string_view_selftests Message-ID: <20190317222004.0afa508d@sf> In-Reply-To: <87ftrob4ha.fsf@tromey.com> References: <20190314222828.28798-1-slyfox@gentoo.org> <87ftrob4ha.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00358.txt.bz2 On Fri, 15 Mar 2019 08:24:17 -0600 Tom Tromey wrote: > >>>>> "Sergei" == Sergei Trofimovich writes: > > Sergei> The build failure was noticed by Helmut Jarausch in > Sergei> https://bugs.gentoo.org/680232: > Sergei> $ ./configure CXXFLAGS='-std=c++17 -Os' > Sergei> ... > Sergei> CXXLD gdb > Sergei> ld: init.o: in function `initialize_all_files()': > Sergei> init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()' > > Sergei> It happens because '_initialize_string_view_selftests()' is > Sergei> conditionally defined based on C++ default. > > Sergei> The change defines '_initialize_string_view_selftests()' > Sergei> unconditionally and leaves implementation a no-op on c++17 > Sergei> compilers. > > Thank you. This is OK with a ChangeLog entry. > Let me know if you need me to check it in for you. Thank you for the quick review! Yes, I need someone to check the change in for me. Should I indicate it the patch email next time? I'll send a follow-up v2 with ChangeLog added and author email matching the company which has agreement already signed with FSF. -- Sergei