From: Tom Tromey <tom@tromey.com>
To: Aaron Merey <amerey@redhat.com>
Cc: Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v3] Add debuginfod support to GDB
Date: Thu, 20 Feb 2020 17:59:00 -0000 [thread overview]
Message-ID: <87ftf5jg12.fsf@tromey.com> (raw)
In-Reply-To: <CAJDtP-RqdfyS9L6xSu6zazrs2U-3FjLZTj9bfcMNidLgUtUKUA@mail.gmail.com> (Aaron Merey's message of "Mon, 10 Feb 2020 18:51:30 -0500")
>>>>> "Aaron" == Aaron Merey <amerey@redhat.com> writes:
Aaron> Thanks for the feedback, I've updated the patch with your suggestions
Aaron> (attached) and I've included some additional comments below.
We've been discussing the patch on irc a bit, and while looking at it I
found a nit.
Aaron> + if (IS_DIR_SEPARATOR (s->filename[0]))
This should probably use IS_ABSOLUTE_PATH.
You can just make this change locally, you don't need to send a new
version of the patch.
Tom
next prev parent reply other threads:[~2020-02-20 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 19:27 Aaron Merey
2020-02-07 20:54 ` Simon Marchi
2020-02-10 23:51 ` Aaron Merey
2020-02-20 17:59 ` Tom Tromey [this message]
2020-02-20 18:02 ` Simon Marchi
2020-02-20 18:50 ` Simon Marchi
2020-02-20 19:43 ` Tom Tromey
2020-02-20 19:55 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftf5jg12.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox