From: Simon Marchi <simark@simark.ca>
To: Aaron Merey <amerey@redhat.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v3] Add debuginfod support to GDB
Date: Thu, 20 Feb 2020 18:50:00 -0000 [thread overview]
Message-ID: <4d971725-4f83-a1d3-80a2-9e54a78c6e56@simark.ca> (raw)
In-Reply-To: <e68290cf-1a5f-218d-2814-1cf5caab121e@simark.ca>
On 2020-02-20 1:02 p.m., Simon Marchi wrote:
> I think we still need something just after the debuginfod_find_debuginfo
> and debuginfod_find_source calls to throw the "quit" exception, if the quit
> flag is set at this point. Without that, the debuginfod_source_query and
> debuginfod_debuginfo_query will return a failure. The calling code could
> therefore conclude that debug info is not available (and cache that value
> somehwere), for a file for which debug info is actually available. When
> the execution reaches the event loop and we process the quit flag, it
> would be too late, the damage will have been done.
Following a discussion on IRC, I changed my mind, the simplest solution
for now would be: when the user cancels a download, GDB will continue
as if debug info was not available for that objfile. However, I would suggest
printing a message saying that the download of debug info for XYZ was cancelled,
so the user is not surprised to not have its debug info.
Simon
next prev parent reply other threads:[~2020-02-20 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 19:27 Aaron Merey
2020-02-07 20:54 ` Simon Marchi
2020-02-10 23:51 ` Aaron Merey
2020-02-20 17:59 ` Tom Tromey
2020-02-20 18:02 ` Simon Marchi
2020-02-20 18:50 ` Simon Marchi [this message]
2020-02-20 19:43 ` Tom Tromey
2020-02-20 19:55 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d971725-4f83-a1d3-80a2-9e54a78c6e56@simark.ca \
--to=simark@simark.ca \
--cc=amerey@redhat.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox